Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: read user default language from browser #1339

Open
wants to merge 1 commit into
base: sepolia
Choose a base branch
from

Conversation

yqrashawn
Copy link
Member

@yqrashawn yqrashawn commented Oct 24, 2024


PR Summary

resolve GEN-1305
read user's default language preference from window.navigator


Checklist

  • There are breaking changes
  • I've added/changed/removed ENV variable(s)
  • I checked whether I should update the docs and did so by updating /docs

Copy link

vercel bot commented Oct 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
frontends ⬜️ Ignored (Inspect) Visit Preview Oct 25, 2024 0:41am

Copy link

netlify bot commented Oct 24, 2024

Deploy Preview for scroll-io ready!

Name Link
🔨 Latest commit 614beaf
🔍 Latest deploy log https://app.netlify.com/sites/scroll-io/deploys/671ae91e79350b0008908988
😎 Deploy Preview https://deploy-preview-1339.env.scroll.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Holybasil
Copy link
Member

maybe we should upgrade the version number to clear the locally stored blogLanguage for users, so it defaults to reading the browser settings? @yqrashawn

Signed-off-by: yqrashawn <namy.19@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants